Bug in diff

utzoo!decvax!ucbvax!mhtsa!ihnss!harpo!eagle!mhuxt!cbosg!cincy!root utzoo!decvax!ucbvax!mhtsa!ihnss!harpo!eagle!mhuxt!cbosg!cincy!root
Mon Apr 19 23:11:13 AEST 1982


The following bug is in the 2.8BSD diff:  When a diff -r is done,
the directories are sorted by qsort before comparisons are done.
The second argument to qsort is a long (because st_size is long,)
but qsort wants an int.  The arguments get screwed up and the sort
never happens...  The fix is as follows:

diff diffdir.c diffdir.old

198c198
< 	qsort(dp, (int)( stb.st_size / sizeof (struct direct) ), 
---
> 	qsort(dp, stb.st_size / sizeof (struct direct), 

	Jim Reuter



More information about the Comp.bugs.2bsd mailing list