Bug in umount code

[Chris Torek]

In article <2713 at pucc-h> ach at pucc-h.UUCP (Stephen Uitti) writes:
>[A bug in umount] is not a bug that's limited to 2.9.  It's
>probably found everywhere, and has existed from the dawn of
>time.

It is not present in 4.2 or 4.1, and probably was not in 4.1 (though
I have to admit I never was familiar with the 4.1 code).  The
`proper' way to fix it is clear; indeed, there is a comment in the
4.2 and 4.3 ufs_bio.c that reads as follows:

/*
 * Invalidate in core blocks belonging to closed or umounted filesystem
 *
 * This is not nicely done at all - the buffer ought to be removed from the
 * hash chains & have its dev/blkno fields clobbered, but unfortunately we
 * can't do that here, as it is quite possible that the block is still
 * being used for i/o. Eventually, all disc drivers should be forced to
 * have a close routine, which ought ensure that the queue is empty, then
 * properly flush the queues. Until that happy day, this suffices for
 * correctness.                                         ... kre
 */

`kre', of course, is Robert Elz.
-- 
In-Real-Life: Chris Torek, Univ of MD Comp Sci Dept (+1 301 454 1415)
UUCP:	seismo!umcp-cs!chris
CSNet:	chris at umcp-cs		ARPA:	chris at mimsy.umd.edu